[PATCH] Fix bug 12419 - AD access check function isn't IPv6-aware.

Andreas Schneider asn at samba.org
Wed Nov 16 07:43:45 UTC 2016


On Wednesday, 16 November 2016 08:16:44 CET Andreas Schneider wrote:
> On Tuesday, 15 November 2016 08:59:35 CET Jeremy Allison wrote:
> > As described in $SUBJECT. Removes the non-IPv6 aware source4/
> > access_check() function by moving the IPv6-aware version from
> > source3/ to the top level and using one common function across
> > all the code. More merged code (yay !).
> > 
> > Tested and confirmed working by the original reporter
> > Heath Kehoe <heath at digitalartefacts.com>.
> > 
> > Please review and push if happy !
> > 
> > Cheers,
> > 
> > 	Jeremy.
> 
> LGTM - Pushed to autobuild.
> 
> 
> For master could you please document allow_access() and allow_access_nolog()
> with Doxygen comments?

While you're at it. The ctdb build fails with your patchset:

cd ctdb
./configure
make -j
WAF_MAKE=1 PATH=buildtools/bin:../buildtools/bin:$PATH waf build
Waf: Entering directory `/home/asn/workspace/projects/samba/ctdb/bin'
Checking project rules ...
Unknown dependency 'interfaces' in 'access'


Please fix :)


	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: look
Type: application/mbox
Size: 38508 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161116/37780737/look.mbox>


More information about the samba-technical mailing list