[PATCH] honour 'disable netbios' config param when using smbclient -L

[David Disseldorp]

On Mon, 14 Nov 2016 14:16:09 +0000, Noel Power wrote:

> On 14/11/16 13:41, David Disseldorp wrote:
> > On Mon, 14 Nov 2016 12:17:32 +0000, Noel Power wrote:
> >  
> >> @@ -5676,6 +5680,10 @@ static int do_message_op(struct user_auth_info *a_info)
> >>  {
> >>  	NTSTATUS status;
> >>  
> >> +	if (lp_disable_netbios()) {
> >> +		return 0;
> >> +	}
> >> +  
> > I think an error should be returned (and printed) for this case.  
> hmm I admit I didn't think about returning an error at all, just
> disabling (as in the -L case). I think that you're right in that it
> makes sense to output a message in this case (because you are explicitly
> trying a netbios thing) but I don't know if you would count that as an
> error or not (I mean returning an error status), the attached patch
> returns an error in any case

Looks good to me:
Reviewed-by: David Disseldorp <ddiss at samba.org>

Cheers, David