[PATCH] bump ldb version number

Andrew Bartlett abartlet at samba.org
Sat Nov 12 19:14:32 UTC 2016

On Sat, 2016-11-12 at 16:50 +0100, Stefan Metzmacher wrote:
> Hi,
> > 
> > Review appreciated!
> As I'm currently working on more ldb features I'd propose the
> attached
> patchset
> for 1.1.28, then we don't need to do 2 releases almost at the same
> time.
> Please have a look.

My only thoughts are:

Do we need the string parser for "recalculate_rdn" or could a control
 just be done via local_oid?

You need to cover in the rdn_name 'normalise' case when the attribute
might be the default from the DB, and have a name of "*", as supported

static const struct ldb_schema_attribute
	struct ldb_context *ldb,
	const char *name)
	/* for binary search we need signed variables */
	unsigned int i, e, b = 0;
	int r;
	const struct ldb_schema_attribute *def =

	/* fallback to default attribute implementation */
	if (name == NULL) {
		return def;

	/* as handlers are sorted, '*' must be the first if present */
	if (strcmp(ldb->schema.attributes[0].name, "*") == 0) {
		def = &ldb->schema.attributes[0];
		b = 1;

That is, ldb_attribute_default has name of NULL, but def from the DB
would have a name of "*".  We should probably make that consistent...

> Thanks!
> metze

I've also got some changes that needs (just because our ABI checker
doesn't know to ignore private functions) an ABI bump:

They are in:

Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list