honour 'disable netbios' config param when using smbclient -L
jra at samba.org
Fri Nov 11 22:08:06 UTC 2016
On Thu, Nov 10, 2016 at 05:35:43PM +0100, David Disseldorp wrote:
> On Thu, 10 Nov 2016 09:16:03 +0000, Noel Power wrote:
> > Hi,
> > We had a customer complaining about the current smbclient behaviour
> > which is if config param 'disable netbios' is set then
> > >smbclient -Ublah%foo -L //server
> > will still try to use the NBT port to list the servers and gives the
> > following error
> > "Connection to [SERVER] failed (Error NT_STATUS_UNSUCCESSFUL)
> > NetBIOS over TCP disabled -- no workgroup available"
> > I opened bug https://bugzilla.samba.org/show_bug.cgi?id=12418 for this
> > so please see the attached patch and bless it if acceptable
> Looks okay to me, Noel. However, there's a chance that it'll upset users
> relying on the existing server-only "disable netbios" behaviour (the man
> page is a little ambiguous WRT what should be affected. Also, if we do
> go down this route, then for consistency it might also be worth
> intervening in do_message_op().
> Interested to hear what others think.
I think this patch is correct, but as David says I'm not sure
it goes far enough. Can you add the same check in do_message_op()
as well ?
More information about the samba-technical