[PATCH] Let s3 epm map call ignore object uuid

[Günther Deschner]

Hi,

just like in the s4 epm server let the map call in the s3 epm server
ignore object_uuid for now.

Please review and push,

Thanks,
Guenther
-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org
-------------- next part --------------
From 0ea9f3d40eb6a41b5682d21db740ae5c7c521d9a Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn at samba.org>
Date: Wed, 26 Oct 2016 18:06:36 +0200
Subject: [PATCH] s3-epmapper: Ignore epm_Map object guid

Tests revealed that you can pass random GUIDs to epm_Map and Windows will
happily answer the query.

Pair-Programmed-With: Guenther Deschner <gd at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Guenther Deschner <gd at samba.org>
---
 source3/rpc_server/epmapper/srv_epmapper.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/source3/rpc_server/epmapper/srv_epmapper.c b/source3/rpc_server/epmapper/srv_epmapper.c
index 24f7d9c..d0e2d54 100644
--- a/source3/rpc_server/epmapper/srv_epmapper.c
+++ b/source3/rpc_server/epmapper/srv_epmapper.c
@@ -101,6 +101,7 @@ static const struct dcesrv_iface *find_interface(const struct dcesrv_endpoint *e
 	return NULL;
 }
 
+#if 0
 /*
  * See if a uuid and if_version match to an interface
  */
@@ -109,6 +110,7 @@ static bool interface_match_by_uuid(const struct dcesrv_iface *iface,
 {
 	return GUID_equal(&iface->syntax_id.uuid, uuid);
 }
+#endif
 
 static struct dcesrv_iface_list *find_interface_list(const struct dcesrv_endpoint *endpoint,
 						     const struct dcesrv_iface *iface)
@@ -218,9 +220,16 @@ static uint32_t build_ep_list(TALLOC_CTX *mem_ctx,
 			const char *host = NULL;
 			const char *host_addr = NULL;
 
+#if 0
+			/*
+			 * Windows ignores the object uuid by default. There is
+			 * one corner case. It is checked for the mgmt
+			 * interface, which we do not implement here yet.
+			 */
 			if (uuid && !interface_match_by_uuid(iface->iface, uuid)) {
 				continue;
 			}
+#endif
 
 			eps = talloc_realloc(mem_ctx,
 					     eps,
-- 
2.7.4

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 201 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161111/e1625062/signature.sig>