[PATCH] Alllow long printer names with /etc/printcap

Andreas Schneider asn at samba.org
Fri Nov 11 06:47:19 UTC 2016


On Thursday, 10 November 2016 11:03:55 CET Jeremy Allison wrote:
> On Thu, Nov 10, 2016 at 11:51:16AM +0100, Andreas Schneider wrote:
> > Hi,
> > 
> > the attached patch allows longer printer names in /etc/printcap and issues
> > a warning if longer ones are found. Older client might not like long
> > printer names.
> > 
> > BUG: https://bugzilla.samba.org/show_bug.cgi?id=12195
> > 
> > 
> > Review and push appreciated!
> 
> Pushed with the removal of the:
> > +     DBG_ERR("ASN\n");
> 

Ups :)

> line :-). Plus addition of a missing talloc_free(frame)
> in the x_fopen() fail return path and cast of MAXPRINTERLEN
> to (unsigned int) to match the %u parameter.

Thanks for pushing!


	Andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list