vfs_fruit option fruit:resource

[Jeremy Allison]

On Tue, Nov 08, 2016 at 06:49:10PM +0100, Stefan Metzmacher wrote:
> Hi Jeremy,
> 
> >>>> On Tue, Nov 08, 2016 at 04:07:07PM +0530, Shilpa K wrote:
> >>>>> Filed bug https://bugzilla.samba.org/show_bug.cgi?id=12412
> >>>>
> >>>> thanks! Patch attached.
> >>>>
> >>>> Someone please review & push if ok. Thanks!
> >>>
> >>> I'd argue that we should not silently change the behavior of existing
> >>> installations, just with an 'apt-get upgrade' from 4.5.1 to 4.5.2.
> >>>
> >>> I see two ways forward:
> >>>
> >>> 1)
> >>> - just change the manpage in 4.5 and older
> >>> - do an incompatible change for 4.6 and use
> >>>   'fruit:resource' with a fallback to 'fruit:ressource'
> >>> - document the mess in the 4.6 manpage
> >>> 2)
> >>> - use a new name e.g. 'fruit:resource method' with a fallback
> >>>   to 'fruit:ressource'
> >>> - document the new name and the broken legacy in the manpage
> >>> - Here we would be able to backport the patches to 4.5 and older
> >>>   and have it at least consistent between 4.5.next, 4.4.next and 4.6.0
> >>>
> >>> I'd tend to 2).
> >>
> >> I'd prefer to wipe the slate as clean as possible, hopefully most
> >> people weren't setting "fruit:resource" to any non-default value
> >> anyway.
> >>
> >> Option 1) that means for me, still thinking about it...
> > 
> > Can't we just make 'fruit:resource' and 'fruit:ressource'
> > synonyms, and accept either ? That's the way we've handled
> > such things in the past.
> 
> I initially thought the same, but then I realized that
> people following the manpage using 'fruit:resource = stream'
> were effectively running with 'fruit:resource = file'.
> So we should not silently change them to
> 'fruit:resource = stream', as that hides the data for existing
> files and tries to set with the (according to Ralph) broken
> 'stream' backend.

Oh, that does make things difficult...

How about just changing the paramter name going forward.

fruit:resource_store

becomes the correct name for 4.6. Detect but issue a warning
for existing 'fruit:resource =' paramter - request
the admin to change them to fruit:resource_store.

Do we have a tool that can migrate the resource data from
one backend to another ?