vfs_fruit option fruit:resource

[Andreas Schneider]

On Tuesday, 8 November 2016 09:35:23 CET Jeremy Allison wrote:
> On Tue, Nov 08, 2016 at 02:15:51PM +0100, Ralph Böhme wrote:
> > On Tue, Nov 08, 2016 at 02:06:57PM +0100, Stefan Metzmacher wrote:
> > > Hi Ralph,
> > > 
> > > > On Tue, Nov 08, 2016 at 04:07:07PM +0530, Shilpa K wrote:
> > > >> Filed bug https://bugzilla.samba.org/show_bug.cgi?id=12412
> > > > 
> > > > thanks! Patch attached.
> > > > 
> > > > Someone please review & push if ok. Thanks!
> > > 
> > > I'd argue that we should not silently change the behavior of existing
> > > installations, just with an 'apt-get upgrade' from 4.5.1 to 4.5.2.
> > > 
> > > I see two ways forward:
> > > 
> > > 1)
> > > - just change the manpage in 4.5 and older
> > > - do an incompatible change for 4.6 and use
> > > 
> > >   'fruit:resource' with a fallback to 'fruit:ressource'
> > > 
> > > - document the mess in the 4.6 manpage
> > > 2)
> > > - use a new name e.g. 'fruit:resource method' with a fallback
> > > 
> > >   to 'fruit:ressource'
> > > 
> > > - document the new name and the broken legacy in the manpage
> > > - Here we would be able to backport the patches to 4.5 and older
> > > 
> > >   and have it at least consistent between 4.5.next, 4.4.next and 4.6.0
> > > 
> > > I'd tend to 2).
> > 
> > I'd prefer to wipe the slate as clean as possible, hopefully most
> > people weren't setting "fruit:resource" to any non-default value
> > anyway.
> > 
> > Option 1) that means for me, still thinking about it...
> 
> Can't we just make 'fruit:resource' and 'fruit:ressource'
> synonyms, and accept either ? That's the way we've handled
> such things in the past.

Well if the manpage states 'fruit:resource', with the correct spelling!

How many users do you think used the incorrect spelling? How many users dive 
to the source code to find incorrect spelled options?



-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org