[PATCH] s3/client/clitar.c: always close fd

Andreas Schneider asn at samba.org
Tue May 31 14:00:04 UTC 2016


On Tuesday, 31 May 2016 15:54:09 CEST Aurélien Aptel wrote:
> Hi,
> 
> Small fix #2, problem also found by coverity.
> 
> Please review&push, thanks!

Hi Aurélien,

thanks for your patch!

We avoid several goto targets in a function. I the fd should be initialized 
with -1 and then in out: do:

out:
	if (fd != -1) {
		close(fd);
	}


Cheers,


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list