[PATCH] samba-tool throws error if there is an empty FSMO role

Rowland Penny repenny241155 at gmail.com
Mon May 30 09:44:59 UTC 2016

On 30/05/16 10:32, Andrew Bartlett wrote:
> On Thu, 2016-05-26 at 10:19 +0100, Rowland Penny wrote:
>> So, it seems to work for ad_dc_ntvfs:local and fl2000dc:local, but
>> fails
>> for fl2003dc:local and fl2008r2dc:local.
>> Is this something I can change and if so, how? or am I running the
>> test
>> incorrectly?
> It just seems to be something wrong with those environments when run
> just for one test.  I can't explain it, but in the full make test it
> works fine, so I think we ignore it for now in the interests of getting
> your patch in.
> Attached is your patches cleaned up (syntax error in the original
> patch, and didn't handle the fl2000dc case for me), and the tests.
>   Please let me know if that is all OK and we can get this in to master.
> Thanks for your patience here!
> For others, the next step in testing this would be to validate the
> output.  I'm not asking that you do it before it gets in, but I do see
> it as the next logical step here.
> Andrew Bartlett

Hi Andrew,

It all looks correct to me and thanks for fixing my error and also 
thanks for your help.


More information about the samba-technical mailing list