[Review Request] binary suffix in search requests

Andrew Bartlett abartlet at samba.org
Mon May 30 09:15:56 UTC 2016

On Wed, 2016-05-18 at 18:28 +0200, Niklas Abel wrote:
> Hey,
> I have written a patch to fix the behavior previously discussed at
> https://lists.samba.org/archive/samba/2015-November/196049.html
> It modifies search requests with a ";binary" suffix.
> If an attributes’ suffix is ";binary" the binary part will simple be
> stripped away.
> The code has been tested locally against NULL, empty strings,
> with and without ";binary" part String behavior.
> The attribute variable has not been fixed as recommended in
> resolve_oids.c
> because the variable is static and can not be changed without
> significant impact to the rest of the code.

Thanks for the patch.   I would still ask that this be done in
resolve_oids, and certainly not in the LDAP server.  We want direct ldb
access and access over LDAP to be as similar as possible, for a number
of reasons, including allowing us to de-couple some internal access to
be over ldapi in the future.

To progress further, we need to have some tests for this, preferably
written in python, to show the behaviour, and then included in make

Finally, yes using the [PATCH] subject does help, as does some
persistence.  Sadly the team handling the AD DC side of things is small
and busy, but we try to keep tabs on patches like this.  The only other
suggestion I have is that submitting a github pull request is pretty
much like mailing your patch here, but at least it stays on a list
there that we occasionally look over.


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list