[PATCH] Small cleanups struct sockaddr -> struct sockaddr_storage

[Jeremy Allison]

On Sun, May 29, 2016 at 12:12:05AM +0300, Uri Simchoni wrote:
> On 05/27/2016 09:48 PM, Jeremy Allison wrote:
> > So after noticing the cleanup in Volker's patch,
> > I did:
> > 
> > git grep 'struct sockaddr ' | grep -v 'struct sockaddr \*'
> > 
> > and here are the 2 cleanups I found that were needed.
> > 
> > Please review and push if you agree. The smbldap one,
> > is that worth a bug report ?
> > 
> > Comments welcome,
> > 
> > Jeremy.
> > 
> Both RB+ me but I have the following comments and therefore not pushing
> (feel free to ignore them and just push):
> 1. The echo server is still IPv4-only because it binds using an AF_INET
> socket (the fix is still correct in that sockaddr variables should not
> exist, only pointers thereof)

Still want to fix this as it's boilerplate that gets
copied to do tevent-async accept - so I'd prefer it
at least be correct for IPv6.

> 2. The smbldap - not a bug IMHO because where do you find a Unix system
> without unix sockets? (and if you don't - do we need this #ifdef...)

Good point. I'll push but then look at the need
for this #idef...