[PATCH] Small cleanups struct sockaddr -> struct sockaddr_storage

Uri Simchoni uri at samba.org
Sat May 28 21:12:05 UTC 2016


On 05/27/2016 09:48 PM, Jeremy Allison wrote:
> So after noticing the cleanup in Volker's patch,
> I did:
> 
> git grep 'struct sockaddr ' | grep -v 'struct sockaddr \*'
> 
> and here are the 2 cleanups I found that were needed.
> 
> Please review and push if you agree. The smbldap one,
> is that worth a bug report ?
> 
> Comments welcome,
> 
> Jeremy.
> 
Both RB+ me but I have the following comments and therefore not pushing
(feel free to ignore them and just push):
1. The echo server is still IPv4-only because it binds using an AF_INET
socket (the fix is still correct in that sockaddr variables should not
exist, only pointers thereof)

2. The smbldap - not a bug IMHO because where do you find a Unix system
without unix sockets? (and if you don't - do we need this #ifdef...)

Thanks,
Uri.



More information about the samba-technical mailing list