[PATCH] Fix replication, re-sort replPropertyMetaData and add many tests

Andrew Bartlett abartlet at samba.org
Fri May 27 06:00:31 UTC 2016


This patch series, is at:

git://git.catalyst.net.nz/samba.git repl_move-replPropertyMetaData

http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/r
epl_move-replPropertyMetaData

This patch series addresses a large number of issues in our replication
code, particularly that we did not correctly honour the parentGUID when
there was no apparent change in the DN, and that we would sometimes
have a 'name' attribute that did not match the RDN.

Finally, we find that our replPropertyMetaData was incorrectly sorted,
and did not match Windows behaviour for our RDN so we fix that.

The code has comprehensive tests, and earlier versions have passed many
autobuilds without flapping in the replication code.  The latest code
is again under test in the Catalyst Cloud. 

Please look at this carefully, if you have time, as this changes some
base assumptions that we had, which I show to be unfounded.  I plan to
merge it late next week after peer-review.

This should address a number of our flapping tests and non-
deterministic behaviours, and make Samba replication much more reliable
for Samba 4.5.

The patch is, at this stage, ready to go, except that I need to decide
on if this patch will have the HACK tag removed, or a better solution
implemented:
http://git.catalyst.net.nz/gitweb?p=samba.git;a=commitdiff;h=5f457a2a76
b731d5c1a5cb4bfa3fd908d149fe7a

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba









More information about the samba-technical mailing list