[PATCH] samba-tool throws error if there is an empty FSMO role

[Rowland Penny]

On 26/05/16 09:15, Andrew Bartlett wrote:
> On Thu, 2016-05-26 at 08:53 +0100, Rowland Penny wrote:
>> On 26/05/16 07:21, Andrew Bartlett wrote:
>>> I do appreciate the work you have done here, have a go with that if
>>> you
>>> get a chance otherwise I'll figure out what is wrong and fix it up
>>> from
>>> here.
>> I have spent hours on this and whilst I think I am close, I just
>> cannot
>> see what I am doing wrong, so I don't think I am going to fix this
>> without help.
> Try changing:
>
> for env in ["ad_dc_ntvfs", "fl2000dc", "fl2003dc", "fl2008r2dc"]:
>      planpythontestsuite(env, "samba.tests.samba_tool.fsmo")
>
> to:
>
> for env in ["ad_dc_ntvfs", "fl2000dc", "fl2003dc", "fl2008r2dc"]:
>      planpythontestsuite(env + ":local", "samba.tests.samba_tool.fsmo")
>
>> Rowland
>>> Thanks!
>>>
>>> Andrew Bartlett
>>>

OK, I have altered the test as suggested and if I now cd into the Samba 
source dir and run (as root):

make test TESTS="samba.tests.samba_tool.fsmo" SUBUNIT_FORMATTER=cat

Amongst the output I get these lines:

successful: 
samba.tests.samba_tool.fsmo.samba.tests.samba_tool.fsmo.FsmoCmdTestCase.test_fsmoget(ad_dc_ntvfs:local)

successful: 
samba.tests.samba_tool.fsmo.samba.tests.samba_tool.fsmo.FsmoCmdTestCase.test_fsmoget(fl2000dc:local)

/home/adminuser/samba-4.4.3/bin/winbindd: STATUS=daemon 'winbindd' 
finished starting up and ready to serve connections
Samba 3112 failed to start up at 
/home/adminuser/samba-4.4.3/selftest/target/Samba4.pm line 161.
samba: EOF on stdin - terminating
failed to start up environment 'fl2003dc' at 
/home/adminuser/samba-4.4.3/selftest/target/Samba.pm line 49.
samba can't start up known environment 'fl2003dc' at 
/home/adminuser/samba-4.4.3/selftest/selftest.pl line 896.
testsuite: samba.tests.samba_tool.fsmo(fl2003dc:local)
testsuite-error: samba.tests.samba_tool.fsmo(fl2003dc:local) [
unable to set up environment fl2003dc:local - exiting

]

/home/adminuser/samba-4.4.3/bin/winbindd: STATUS=daemon 'winbindd' 
finished starting up and ready to serve connections
Samba 3480 failed to start up at 
/home/adminuser/samba-4.4.3/selftest/target/Samba4.pm line 161.
samba: EOF on stdin - terminating
failed to start up environment 'fl2008r2dc' at 
/home/adminuser/samba-4.4.3/selftest/target/Samba.pm line 49.
samba can't start up known environment 'fl2008r2dc' at 
/home/adminuser/samba-4.4.3/selftest/selftest.pl line 896.
testsuite: samba.tests.samba_tool.fsmo(fl2008r2dc:local)
testsuite-error: samba.tests.samba_tool.fsmo(fl2008r2dc:local) [
unable to set up environment fl2008r2dc:local - exiting

]

teardown_env(ad_dc_ntvfs)

So, it seems to work for ad_dc_ntvfs:local and fl2000dc:local, but fails 
for fl2003dc:local and fl2008r2dc:local.
Is this something I can change and if so, how? or am I running the test 
incorrectly?

Rowland