[PATCH] samba-tool throws error if there is an empty FSMO role

[Andrew Bartlett]

On Thu, 2016-05-26 at 08:53 +0100, Rowland Penny wrote:
> On 26/05/16 07:21, Andrew Bartlett wrote:

> > 
> > I do appreciate the work you have done here, have a go with that if
> > you
> > get a chance otherwise I'll figure out what is wrong and fix it up
> > from
> > here.
> 
> I have spent hours on this and whilst I think I am close, I just
> cannot 
> see what I am doing wrong, so I don't think I am going to fix this 
> without help.

Try changing:

for env in ["ad_dc_ntvfs", "fl2000dc", "fl2003dc", "fl2008r2dc"]:
    planpythontestsuite(env, "samba.tests.samba_tool.fsmo")

to:

for env in ["ad_dc_ntvfs", "fl2000dc", "fl2003dc", "fl2008r2dc"]:
    planpythontestsuite(env + ":local", "samba.tests.samba_tool.fsmo")

> Rowland
> > 
> > Thanks!
> > 
> > Andrew Bartlett
> > 
> 
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba