[PATCH] samba-tool throws error if there is an empty FSMO role

[Andrew Bartlett]

On Wed, 2016-05-11 at 20:06 +0100, Rowland Penny wrote:
> On 11/05/16 19:55, Andrew Bartlett wrote:
> > On Wed, 2016-05-11 at 15:51 +0100, Rowland Penny wrote:
> > 
> > > OK, if I set up an fl2000dc testenv and run:
> > > 
> > > make test TESTS="samba.tests.samba_tool.fsmo"
> > > SUBUNIT_FORMATTER=cat
> > > 
> > > and get:
> > > 
> > > testsuite-failure: samba.tests.samba_tool.fsmo(fl2000dc:local)
> > > 
> > > and then patch fsmo.py and re-run:
> > > 
> > > make test TESTS="samba.tests.samba_tool.fsmo"
> > > SUBUNIT_FORMATTER=cat
> > > 
> > > and get:
> > > 
> > > testsuite-success: samba.tests.samba_tool.fsmo(fl2000dc:local)
> > > 
> > > Does this mean I have a test for 'samba-tool fsmo show' that
> > > works ?
> > Quite likely, yes!
> > 
> > Indeed, you have found the correct approach of checking the test
> > fails
> > in the 'before' case (something we can forget to actually verify).
> > 
> > Now just make it run in the other environments as well (see
> > elsewhere
> > in the file for the for loop pattern across ad_dc_ntvfs, fl2003dc
> > and
> > fl2008dc), and post the patch!
> > 
> > Andrew Bartlett
> > 
> 
> I am lying down in a darkened room to recover :-)
> I will then try to run it as you suggest.

I'm looking forward to reviewing the patches as soon as you can post
them.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba