[PATCH] sync samba pidl with wireshark pidl
David Disseldorp
ddiss at suse.de
Tue May 24 17:44:59 UTC 2016
On Wed, 18 May 2016 17:28:40 +0200, Aurélien Aptel wrote:
> On Wed, 18 May 2016 14:03:32 +0200 Aurélien Aptel <aaptel at suse.com>
> wrote:
> > It also happens in the wireshark repo. Will look into it.
Thanks for fixing this.
>
> I've added 2 patches to the patchset.
>
> #19 fixes 2 test failures in the Pidl test suite.
> - commit 02cd7808 changed the error the test was expecting
> => update expected output in the test
> - commit c76b65e changed whitespaces in the output
> => revert to the old output in the generator
>
> #20 is from the Wireshark repo that and fixes the generated MAPI
> dissector (couldnt compile previously). Note: it is not generated in samba.
These two new changes look good to me. @Metze: please push if you're
happy.
Cheers, David
More information about the samba-technical
mailing list