[PATCH] heimdal - align kvno internal type with upstream

Uri Simchoni uri at samba.org
Sat May 21 19:43:42 UTC 2016


This is just supposed to help merging upstream Heimdal (I know some
still want to do it so the least I can do is not get in the way and make
my patches compatible with upstream - this patch fixes that).


On 05/17/2016 10:48 PM, Uri Simchoni wrote:
> Hi,
> I tried pushing the changes of commit
> 6379737b7ddc6ccb752238c5820cc62e76a8da17 to upstream heimdal (the kvno
> signedness, affecting RODC). It turns out the encoding in upstream
> Heimdal has long been changed to signed, but the internal representation
> of kvno remains unsigned and they want to keep it that way. The upstream
> code included a pointer type mismatch which would make our picky build
> modes scream, and I fixed that (with Andrew pushing it).
> In the interest of aligning our fork and heimdal (sigh...), this patch
> reverts the internal representation change and takes care of
> signed->unsigned conversion. The goal is no functional changes to Samba
> - it just makes the code more similar to upstream Heimdal (not identical
> because there are subtle differences which are out of scope for this
> change).
> Review appreciated,
> Uri.

More information about the samba-technical mailing list