[PATCH] Convert Samba to OFD locking - version 2

Jeff Layton jlayton at samba.org
Fri May 20 11:01:18 UTC 2016


On Thu, 2016-05-19 at 14:12 -0700, Jeremy Allison wrote:
> OK, here is version 2 with Uri and Simo's changes
> incorporated. Compile-time checks now run the test
> code rather than just compiling, and there's a
> tuneable "smbd:force process locks" that will force
> the old-style process specific locks. Advice to
> use it gets printed in the log if fcntl returns
> EINVAL.
> 
> Please review and push if happy !
> 
> Thanks,
> 
> Jeremy.

Looks reasonable to me, though again, I don't know the userland samba
code that well. So, fwiw...

    Acked-by: Jeff Layton <jlayton at samba.org>

...also attached is an untested patch for cifsfs, which I was thinking
would do the right thing wrt lockowners. I'll test it out as soon as I
can put a test rig together for it. In the meantime, thoughts?

-- 
Jeff Layton <jlayton at samba.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cifs-stuff-the-fl_owner-into-pid-field-in-the-lock-r.patch
Type: text/x-patch
Size: 3158 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160520/ef8ea52d/0001-cifs-stuff-the-fl_owner-into-pid-field-in-the-lock-r.bin>


More information about the samba-technical mailing list