[PATCH] Convert Samba to OFD locking.

Jeremy Allison jra at samba.org
Thu May 19 17:29:59 UTC 2016


On Thu, May 19, 2016 at 05:14:51PM +0000, Simo wrote:
> It will be extremely common actually, compile time and runtime are just 2 different beasts,

That implies a Samba compiled with a recent glibc on a
modern kernel being moved to a system with an older glibc
and kernel.

Do you really want to support that ? What cases do you
need to support that ? Do you have a common case you're
trying to support ?

> at the very least we need a config option to turn off ofd and fallback to the classic locking,
> but that's really not admin friendly, it is easy enough to test if ofd is actually supported st runtime, you try and if you get enosys you log it and turn off the ofd path.

That's *exactly* the kind of runtime complexity I'm trying
to avoid. See my tevent_epoll post for an explaination of
why.

I did think long and hard before coding it up this way,
and did have a good reason for doing so.

I'm really trying to avoid a global "have_working_ofd_locking"
variable.



More information about the samba-technical mailing list