[PATCH] Convert Samba to OFD locking.

Simo Sorce idra at samba.org
Thu May 19 18:25:27 UTC 2016


On Thu, 2016-05-19 at 11:09 -0700, Jeremy Allison wrote:
> On Thu, May 19, 2016 at 01:57:15PM -0400, Simo wrote:
> > 
> > 
> > Given locks are kind of advisory anyway in POSIX I think I can
> > agree on
> > just logging, but then what is the user to do ? recompile ? That is
> > not
> > always possible. I am ok not doing a runtime check if we can have
> > smb.conf option to force to use classic locking.
> > People would have to manually set it (default to auto) if they want
> > to
> > use classic but at least they have the option to have locking work
> > and
> > silence the slew of level 0 logs about locking being broken.
> Ok. I can live with a global "smbd:process-specific locks" smb.conf
> option that
> is set to "no" by default. I'd only have to check it in one place.
> 
> It would only get set on systems where people noticed the
> log spam anyway :-).

Yes, remediation, but at least they'll have a knob :)

Simo.




More information about the samba-technical mailing list