Usability of 'samba-tool domain provision'

[Rowland Penny]

On 11/05/16 12:07, Andreas Schneider wrote:
> On Thursday, May 05, 2016 09:30:04 AM Rowland Penny wrote:
>> On 04/05/16 23:01, Andrew Bartlett wrote:
>>> On Wed, 2016-05-04 at 11:09 +0100, Rowland Penny wrote:
>>>> On 04/05/16 10:29, Peter C. Kelly wrote:
>>>>> Andreas said:
>>>>>> This documents issues I
>>>>>> found during provisioning. samba-tool is far away from being user
>>>>>> friendly.
>>>>>> a) It isn't clear what domain is from 'samba-tool domain provison
>>>>>> --help'
>>>>> I have raised bug 11894, and attached a patch which addresses this
>>>>> point as per Rowland's suggested wording.
>>>>>
>>>>>> b) The --realm option is essential but at the end of the help ...
>>>>> The reason that the realm is way down the bottom is that it is
>>>>> under a
>>>>> heading "Samba Common Options", along with configFile debuglevel
>>>>> and
>>>>> option.
>>>>>
>>>>> What is currently holding me up from developing the second trivial
>>>>> patch is a need for a bit more clarity on how this --help output
>>>>> should look.  It seems to me that if the --domain parameter is
>>>>> compulsory, then the heading text should say so,
>>>>> and that if a realm has to be specified (or read in from an
>>>>> existing
>>>>> conf file) then perhaps that should be mentioned in the
>>>>> introductory
>>>>> text as well.
>>>>>
>>>>> As I am a first time contributor I would be happy to make these
>>>>> trivial changes, if I can get further input on what changes are
>>>>> desirable.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Peter
>>>> Hi, I did some work on this and sent Andreas a new domain.py that
>>>> addressed all of the issues he raised, I am still awaiting a reply
>>>> from
>>>> Andreas (hint, hint)
>>> Rowland,
>>>
>>> Can you please post the patches to the mailing list?
>>>
>>> I'm planning on merging the trivial typos in the meantime, it makes no
>>> sense to block a new contributor while you look at the larger issues.
>>>
>>> Thanks,
>>>
>>> Andrew Bartlett
>> OK, here is the patch I am working on, it changes the provision command
>> somewhat, you can now only provision a DC, for instance.
>>
>> It is a work in progress, I have not tested it fully yet.
> This looks already good. Could you split it into several smaller patches
> please?
>
>
> Thanks,
>
>
>    -- andreas

OK, I given up with the 'spaghetti knitting' for the moment, the 
spaghetti is winning and I needed a rest, so I had a look at this :-)

I have split the patch into several smaller patches:

The first patch makes the required changes to only provision a DC, this 
is because, as far as I an aware, this is the only thing you can really 
provision.

The second patch makes 'realm' & 'domain' required arguments, they are 
no longer options.

The third patch checks if the NetBIOS domain name is too long and exits 
if it is. This also fixes bug 11925

The fourth patch adds Administrator password checking

The fifth patch adds a couple of extra questions to 'interactive', 
use_xattrs and use_rfc2307

The sixth and final patch adds a few examples to help.

Rowland

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tool-domain-provision-remove-unu.patch
Type: text/x-diff
Size: 2480 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160519/69570b52/0001-samba-tool-domain-provision-remove-unu.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-samba-tool-domain-provision-make-realm-domain-requir.patch
Type: text/x-diff
Size: 4131 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160519/69570b52/0002-samba-tool-domain-provision-make-realm-domain-requir.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-samba-tool-domain-provision-check-length-of-NetBIOS-.patch
Type: text/x-diff
Size: 1019 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160519/69570b52/0003-samba-tool-domain-provision-check-length-of-NetBIOS-.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-samba-tool-domain-provision-ensure-Administrator-pas.patch
Type: text/x-diff
Size: 3643 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160519/69570b52/0004-samba-tool-domain-provision-ensure-Administrator-pas.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-samba-tool-domain-provision-make-interactive-ask-if-.patch
Type: text/x-diff
Size: 1342 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160519/69570b52/0005-samba-tool-domain-provision-make-interactive-ask-if-.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-samba-tool-domain-provision-add-examples-to-help.patch
Type: text/x-diff
Size: 2031 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160519/69570b52/0006-samba-tool-domain-provision-add-examples-to-help.diff>