[PATCH] Convert Samba to OFD locking.

Uri Simchoni uri at samba.org
Thu May 19 05:14:06 UTC 2016


On 05/19/2016 12:42 AM, Jeremy Allison wrote:
> Hi Jeff, Steve and Simo,
> 
> Here is the patchset we discussed to convert
> smbd to open file description locking on
> modern kernels. It also includes a regression
> test to ensure we stay working even on systems
> that don't have the required kernels :-).
> 
> Now all we need is the fix you and I discussed
> to the calls to CIFSSMBPosixLock() to convert
> the lock context from current->tgid for process-associated
> record locks to a handle-specific lock context
> for open file description record locks.
> 
> This will put us in really good shape for
> doing the OFD-POSIX locks we need in the
> SMB2+ UNIX extensions protocol changes.
> 
> Please review and let me know !
> 
> Cheers,
> 
> Jeremy.
> 
Seems like the wscript test is a compile-time test. Should be a test
that runs code to verify the kernel actually supports it (or gets it
from the answer file and fails if there's no answer). The fcntl_lock
test just above it can be a good reference.

Just my 2c, I have some learning curve to understand locking.

Uri.




More information about the samba-technical mailing list