[PATCH] An option in 'net ads dns' command to remove a DNS hostname

[James Johnston]

On 2016-03-29 at 09:49 +0000, Michael Adam wrote:
> On 2016-03-18 at 19:17 +0000, Shyam Rathi wrote:
> > Thanks Uri, Michael.
> > 
> > Do I need to prepare a test case for this new command (dns
> > unregister)?
>
> Hm, Andreas kind of requested this. But then, we don't
> seem to have tests for the 'net ads dns register'
> commands either. I can only find reference in
> wintest/test-s3.py . So given that we have no testsuite
> for this yet, I would personally not require a testcase
> before accepting this new subcommand. But we should
> make sure to create tests for these commands. That would
> be incredibly useful!
>
> What do others think!

Any chance that this patch will make it?  This seems like a
useful / fundamental feature that is currently absent.

I agree automated code tests are important, but if even the original dns
register command doesn't have a test, is it still reasonable to require Shyam
to come up with tests when the original "dns" subcommand is untested as well?
As it currently stands, it seems like "dns register" already has bugs &
brokenness with IPv6 and maybe requiring automated tests & fixes for that
existing command before "unregister" contribution can be accepted might be out
of the scope here?  (And, requiring an automated test for "unregister" but not
"register" wouldn't make much sense to me either... especially since both might
be useful for doing a single test...)

Best regards,

James Johnston