[patchset] introduce an -O3 autobuild target - and fix a lot of errors

[Michael Adam]

ENOATTACHMENT -- fixed... :-)

On 2016-05-13 at 00:23 +0200, Michael Adam wrote:
> On 2016-05-12 at 18:28 +0200, Christian Ambach wrote:
> > Hi Michael,
> > 
> > 
> > >> Patchset still applies/rebases cleanly after the sec.update.
> > > 
> > > Given we keep the extra target, can you just add an update to
> > > the .travis.yml as well would be great, so we test it on
> > > github pushes?
> > > 
> > > With that added, the autobuild.py changes are Reviewed-by:
> > > me, but the rest I'll leave for others to comment on.
> > The other patches are Reviewed-by: me. However, now errors have
> > shown up on my machine. I need the attached two additional patches.
> > Can you review them and then push everything together?
> 
> Thanks for the review, Christian!
> Your patches are reviewed-by: me.
> I pushed them without the autobuild changes.
> 
> Andrew:
> Attached find the autobuild changes and the
> .travis.yml addition.
> 
> Michael
> 


-------------- next part --------------
From 51380efa293139f45c8cc81331cb305de651a3b7 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Tue, 22 Mar 2016 18:14:17 +0100
Subject: [PATCH 1/3] autobuild: add a target samba-o3 that is built with -O3

Only run quicktest against the ad_dc env.
This currently just takes some 6 odd minutes.

Signed-off-by: Michael Adam <obnox at samba.org>
---
 script/autobuild.py | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/script/autobuild.py b/script/autobuild.py
index ee16f5b..7c572cd 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -24,6 +24,7 @@ builddirs = {
     "ctdb"    : "ctdb",
     "samba"  : ".",
     "samba-xc" : ".",
+    "samba-o3" : ".",
     "samba-ctdb" : ".",
     "samba-libs"  : ".",
     "samba-static"  : ".",
@@ -79,6 +80,14 @@ tasks = {
                     " --cross-answers=./bin-xe/cross-answers.txt --with-selftest-prefix=./bin-xa/ab" + samba_configure_params, "text/plain"),
                    ("compare-results", "script/compare_cc_results.py ./bin/c4che/default.cache.py ./bin-xe/c4che/default.cache.py ./bin-xa/c4che/default.cache.py", "text/plain")],
 
+    # test build with -O3 -- catches extra warnings and bugs
+    "samba-o3" : [ ("random-sleep", "../script/random-sleep.sh 60 600", "text/plain"),
+                   ("configure", "ADDITIONAL_CFLAGS='-O3' ./configure.developer --with-selftest-prefix=./bin/ab" + samba_configure_params, "text/plain"),
+                   ("make", "make -j", "text/plain"),
+                   ("test", "make quicktest FAIL_IMMEDIATELY=1 TESTS='\(ad_dc\)'", "text/plain"),
+                   ("install", "make install", "text/plain"),
+                   ("check-clean-tree", "script/clean-source-tree.sh", "text/plain"),
+                   ("clean", "make clean", "text/plain") ],
 
     "samba-ctdb" : [ ("random-sleep", "script/random-sleep.sh 60 600", "text/plain"),
 
-- 
2.5.5


From 6d20d57b86b72583e6f326a1760ea056b9cc0bf6 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Mon, 11 Apr 2016 10:23:00 +0200
Subject: [PATCH 2/3] autobuild: run the samba-o3 target by default

Signed-off-by: Michael Adam <obnox at samba.org>
---
 script/autobuild.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/script/autobuild.py b/script/autobuild.py
index 7c572cd..0af8166 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -39,7 +39,7 @@ builddirs = {
     "retry"   : "."
     }
 
-defaulttasks = [ "ctdb", "samba", "samba-xc", "samba-ctdb", "samba-libs", "samba-static", "ldb", "tdb", "talloc", "replace", "tevent", "pidl" ]
+defaulttasks = [ "ctdb", "samba", "samba-xc", "samba-o3", "samba-ctdb", "samba-libs", "samba-static", "ldb", "tdb", "talloc", "replace", "tevent", "pidl" ]
 
 samba_configure_params = " --picky-developer ${PREFIX} ${EXTRA_PYTHON} --with-profiling-data"
 
-- 
2.5.5


From 73219021b418dc1a2a4928c6b1a93234f0ae6784 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Fri, 13 May 2016 00:00:48 +0200
Subject: [PATCH 3/3] travis: run the samba-o3 target

Signed-off-by: Michael Adam <obnox at samba.org>
---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.travis.yml b/.travis.yml
index b930cfe..cf1b0d2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -11,6 +11,7 @@ env:
   - TASK=samba-ctdb
   - TASK=samba-libs
   - TASK=samba-static
+  - TASK=samba-o3
   - TASK=ldb
   - TASK=tdb
   - TASK=talloc
-- 
2.5.5

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160513/cef34513/signature.sig>