[PATCH] shadow_copy2: Allow configurable prefix for snapshots

Michael Adam obnox at samba.org
Thu May 12 12:04:16 UTC 2016

On 2016-05-12 at 16:24 +0530, Rajesh Joseph wrote:
> On Wed, May 11, 2016 at 3:00 AM, Michael Adam <obnox at samba.org> wrote:
> >
> > The twrp context is the smb2-way of requesting
> > previous versions. It is conceptually much cleaner than
> > the horrbile arbitrariness of injecting an @GMT-token
> > into the path somewhere... :-) And we do not ignore it,
> > but we treat it by (hold-your-breath) ... injecting a
> > correpsonding @GMT-component into the path (as the first
> > component). See source3/smbd/smb2_create.c, line 900 ff.
> > This is ugly but it works. And it ensures currently, that
> > we enter the module code with the same kind of data, even
> > if the client used twrp.
> >
> Frankly speaking I have not looked into "time warp". I am not sure
> how will it impact my current patch. I will take a look at this and
> get back to you on this.

As twrp time stamps are converted to @GMT path components before
hitting the vfs, it does not impact your patch at all! :-)

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160512/618d9cda/signature.sig>

More information about the samba-technical mailing list