[PATCH] Fix Bug 11354

[Jeremy Allison]

On Wed, May 11, 2016 at 01:06:49PM +0200, Christian Ambach wrote:
> Hi list,
> 
> please review and potentially push.
> Bug reporter confirmed that fix is functional.

Looking in MS-CIFS it says that the
max data response length is zero, not 2.
(section 2.2.6.7.2).

So couldn't this be:

> +                        data,  data_len, 0

instead ?


> From 7bf5d7577f1546a91782b84278791dd3dea47ab5 Mon Sep 17 00:00:00 2001
> From: Christian Ambach <ambi at samba.org>
> Date: Tue, 10 May 2016 19:47:02 +0200
> Subject: [PATCH] s3:libsmb/clifile use correct value for MaxParameterCount for
>  setting EAs
> 
> Windows servers will refuse trans2 requests which use excessive
> request parameters. From [MS-CIFS|:
> <239> Section 3.3.5.2.5: Windows NT servers fail a transaction request with
> STATUS_INSUFF_SERVER_RESOURCES, if (SetupCount + MaxSetupCount +
> TotalParameterCount + MaxParameterCount + TotalDataCount + MaxDataCount)
> is greater than 65*1024.
> 
> When attempting to set a large list of EAs for a file, this limit can be
> hit when using CLI_BUFFER_SIZE as MaxParameterCount
> while the TRANS2_SET_PATH_INFORMATION response is only two bytes long.
> 
> Be as minimal as possible here to allow a maximum number of EAs to
> be written.
> 
> Bug: https://bugzilla.samba.org/show_bug.cgi?id=11354
> 
> Signed-off-by: Christian Ambach <ambi at samba.org>
> ---
>  source3/libsmb/clifile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c
> index 0e790cd..a0fa623 100644
> --- a/source3/libsmb/clifile.c
> +++ b/source3/libsmb/clifile.c
> @@ -4593,7 +4593,7 @@ static NTSTATUS cli_set_ea(struct cli_state *cli, uint16_t setup_val,
>  	status = cli_trans(talloc_tos(), cli, SMBtrans2, NULL, -1, 0, 0,
>  			   setup, 1, 0,
>  			   param, param_len, 2,
> -			   data,  data_len, CLI_BUFFER_SIZE,
> +			   data,  data_len, 2,
>  			   NULL,
>  			   NULL, 0, NULL, /* rsetup */
>  			   NULL, 0, NULL, /* rparam */
> -- 
> 1.9.1
>