Patch: Make net ads dns gethostbyname print out a result

Andreas Schneider asn at samba.org
Tue May 10 09:54:06 UTC 2016


On Monday, May 09, 2016 07:22:41 AM Richard Sharpe wrote:
> Hi folks,
> 
> I noticed that net ads dns gethostbyname does something but prints nothing.
> 
> Attached is a patch to get it to print stuff out so we can use it in self
> tests.
> 
> I anticipate a storm of suggestions for improvements. Storm away!

Hi,

could you please add brackets for if-clauses. We do not want a 'goto fail' bug 
;)

Also we should first fix socket_wrapper. Write a test for this code and then 
push everything at once.


Thanks,


	-- andreas



More information about the samba-technical mailing list