[PATCHES] remove unnecessary calls to str_list_length

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Fri May 6 03:48:26 UTC 2016


Provision was spending a noticeable portion of its time in this
function, which has walk the length of a char** list. In some places
the caller doesn't care about the length and just wants to know if it
is non-zero. In others it is going to walk the list anyway, repeating
the same work.

I don't have any numbers to say whether this is actually quicker.

Douglas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: str_list_length-begone.patch
Type: text/x-diff
Size: 5862 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160506/5de81b5d/str_list_length-begone.diff>


More information about the samba-technical mailing list