Patch: eliminate duplicate definition of test_smbclient in the testprogs

[Andrew Bartlett]

On Sun, 2016-04-24 at 11:13 -0700, Richard Sharpe wrote:
> Hi folks,
> 
> Attached is a patch that extracts the duplicated shell function
> test_smbclient into an include file called common_test_fns.inc and
> then makes those test progs that were defining it source that file
> and
> use that definition.
> 
> Comment, review, push if deemed appropriate ...

I've seen Ralph's comments, but aside from that I really wanted to say
a big thanks and give an encouragement for working on and tidying up
our selftest code.  It is an arcane mess in parts, and hasn't always
had the love it needs, so I really appreciate your efforts to improve
it, and extend the coverage!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba