Testing adding SPNs at join (was: Re: [PATCH] Patch for bug 1703)

Andrew Bartlett abartlet at samba.org
Thu May 5 17:53:58 UTC 2016


On Mon, 2016-05-02 at 17:50 +0200, Ralph Boehme wrote:
> Hi!
> 
> Attached is a patch to fix bug 1703:
> 
> s3:libnet:libnet_join: add netbios aliases as SPNs
> 
> Add all listed smb.conf netbios aliases as SPNs to the machine
> account:
> 
>   HOST/NETBIOS_ALIAS at REALM
> 
> and
> 
>   HOST/netbios_alias.dnsdomain.name at REALM
> 
> I wasn't entirely sure where to pull the DNS name info from, but
> decided against calling getaddrinfo() on the netbios alias via
> name_to_fqdn(), but instead just pick up the DNS domain name from
> r->out.dns_domain_name.
> 
> Please review and push if ok, thanks!

Can we have a test for this added?

It should just involve adding an alias to setup_admember() in
selftest/target/Samba3.pm and ensuring smbclient -k works against that
name in a blackbox test.

With regards to the DNS name, do we attempt to register netbios aliases
as DNS names?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list