[PATCH] Add remote arch caching

Jeremy Allison jra at samba.org
Tue May 3 19:01:40 UTC 2016


On Tue, May 03, 2016 at 07:52:06PM +0200, Ralph Boehme wrote:
> On Mon, May 02, 2016 at 03:43:07PM -0700, Jeremy Allison wrote:
> > On Mon, May 02, 2016 at 03:36:15PM -0700, Jeremy Allison wrote:
> > > On Mon, May 02, 2016 at 02:31:36PM -0700, Jeremy Allison wrote:
> > > > On Wed, Apr 27, 2016 at 05:49:33PM +0200, Ralph Boehme wrote:
> > > > > Hi Volker!
> > > > > 
> > > > > Attached is an updated patchset with the discussed changes:
> > > > > 
> > > > > o move variable declaration out of the for loop
> > > > > 
> > > > > o fix blob checking in the gencache_parse() parser ra_parse()
> > > > > 
> > > > > Thanks!
> > > > > -Ralph
> > > > 
> > > > LGTM. Pushed with a couple of const additions and
> > > > making the timeout check consistent with other uses !
> > > 
> > > Ah, this is failing in autobuild on:
> > > SMB2-SESSION-REAUTH, I'll try and take
> > > a look (or you can if you get to it
> > > first :-). I'll try with your exact
> > > patch also just to make sure I didn't
> > > break anything in my const changes.
> > 
> > Nope, wasn't my change.
> 
> sorry, looks like the private autobuild I *thought* I had fired, was
> still sitting there in screen waiting for me tho hit enter. :/ I did a
> lot of manual testing from an OS X client, as it turns out that didn't
> catch some serious flaws.
> 
> Attached is an updated patchset that fixes the following issues:
> 
> - gencache requires root privileges, so used (un)become_root() :/
> 
> - gencache_parse() can and will return deleted entries, skip the part
>   that tried to delete expired cache entries, gencache takes care of
>   it anyway
> 
> This version did pass a private autobuild.

Much better thanks ! Pushed.



More information about the samba-technical mailing list