[PATCH] Fixes to CTDB protocol handling

[Amitay Isaacs]

On Tue, May 3, 2016 at 10:56 AM, Martin Schwenke <martin at meltin.net> wrote:

> On Mon, 2 May 2016 17:01:54 +1000, Amitay Isaacs <amitay at gmail.com>
> wrote:
>
> > On Fri, Apr 29, 2016 at 4:43 PM, Amitay Isaacs <amitay at gmail.com> wrote:
> >
> > >
> > > On Thu, Apr 28, 2016 at 11:38 PM, Amitay Isaacs <amitay at gmail.com>
> wrote:
> > >
> > >> Hi,
> > >>
> > >> As per suggestion from Volker, I have modified the marshaling API for
> > >> protocol elements to match the marshaling API used for basic data
> types
> > >> (using len, push, pull).
> > >>
> > >> Please review and push.
> > >>
> > >>
> > > It turns out I introduced an error in the code which sets the packet
> > > length wrong.  Please ignore these patches.  Improved patches with
> > > appropriate test fixes coming.
> > >
> > >
> > Here are the modified patches.
> >
> > Please review and push.
>
> Reviewed-by: Martin Schwenke <martin at meltin.net>
>
> Pushed...
>
> peace & happiness,
> martin
>

Here are some more fixes as suggested by Volker.  Add checks before using
data on wire and checks integer wrapping.

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patches
Type: application/octet-stream
Size: 25021 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160503/33870e8f/ctdb.obj>