[PATCH] LDB: Redudant test on NULL context remove

Petr Cech pcech at redhat.com
Thu Mar 31 06:27:28 UTC 2016


On 03/30/2016 06:32 PM, Jeremy Allison wrote:
> On Wed, Mar 30, 2016 at 08:57:58AM +0200, Petr Cech wrote:
>> On 03/21/2016 02:52 PM, Petr Cech wrote:
>>> Hi list,
>>>
>>> I have found something during work on SSSD stuff which looks like little
>>> bug or bad intention.
>>>
>>> I would like to ask you for careful review of this situation. You could
>>> see more information in head of attached patch.
>>>
>>> Regards
>>>
>>
>> bump :-)
>
> Sorry, this has fallen out of my Inbox. Can you
> resend the details ?
>

Hello Jeremy,

my "bump" mail has been misunderstanding. I had wrong settings for this 
mail list. I haven't see that there were answers.


For clarity:

original mail is
https://lists.samba.org/archive/samba-technical/2016-March/113068.html

the main idea is

"There is redudant test on NULL context in ldb_dn_new_fmt() function.
We use this (NULL) context in talloc_vasprintf() function which is
able to work with NULL at all. And at the end, we free this newly
created (by talloc_vasprintf) context. So it should be safe to remove
this check."


Regards

-- 
Petr^4 Čech



More information about the samba-technical mailing list