[PATCH] ldb_controls: avoid unnecessary unchecked talloc_asprintf()s

[Garming Sam]

Reviewed-by: Garming Sam <garming at catalyst.net.nz>

Can someone else review this, to get sn-devel-104 going again?


Cheers

On 23/03/16 10:57, Douglas Bagnall wrote:
> hi Metze,
>
> On 23/03/16 10:38, Stefan Metzmacher wrote:
>> Can you have a look at this build failure, please?
>>
>> http://git.samba.org/autobuild.flakey.sn-devel-104/2016-03-22-2007/samba.stderr
>>
>> [1902/4035] Compiling source4/dsdb/samdb/ldb_modules/vlv_pagination.c
>> cc1: warnings being treated as errors
>> ../source4/dsdb/samdb/ldb_modules/vlv_pagination.c: In function
>> 'vlv_results':
>> ../source4/dsdb/samdb/ldb_modules/vlv_pagination.c:335: error:
>> declaration of 'index' shadows a global declaration
>> /usr/include/string.h:487: error: shadowed declaration is here
>> Waf: Leaving directory `/memdisk/autobuild/fl/b2864160/samba/bin'
>> Build failed:  -> task failed (err #1):
>> 	{task: cc vlv_pagination.c -> vlv_pagination_90.o}
>> make: *** [all] Error 1
> I think this should fix it.
>
> Douglas
>