Patch: Another attempt at VFS functions for setting and getting DOS attributes

[Jeremy Allison]

On Wed, Mar 23, 2016 at 10:02:05PM -0700, Jeremy Allison wrote:
> On Wed, Mar 23, 2016 at 09:54:15PM -0700, Richard Sharpe wrote:
> > Hi folks,
> > 
> > I think this is getting closer.
> > 
> > However, I still have to deal with one of Uri's concerns (the
> > fget_dos_attr function).
> > 
> > I also used discard_const to squash an annoying error message. I plan
> > to submit another patch to constify some more struct smb_filenames ..
> 
> > @@ -309,11 +309,12 @@ static bool get_ea_dos_attribute(connection_struct *conn,
> >  		case 1:
> >  			dosattr = dosattrib.info.info1.attrib;
> >  			if (!null_nttime(dosattrib.info.info1.create_time)) {
> > +				struct smb_filename *fname = discard_const(smb_fname);
> >  				struct timespec create_time =
> >  					nt_time_to_unix_timespec(
> >  						dosattrib.info.info1.create_time);
> 
> I don't think using discard_const is the right thing to
> do here.
> 
> Let me take a closer look at this tomorrow.

FYI - I have a finished version of this under local
make test that I think is the right way to do this.

Didn't want you to waste more time on this - I'll
publish for review once it's passed make test.