Patch: Fix an obvious error where we forgot to return an error

Jeremy Allison jra at samba.org
Thu Mar 24 23:49:27 UTC 2016


On Wed, Mar 23, 2016 at 10:02:42PM -0700, Richard Sharpe wrote:
> Hi folks,
> 
> Here is a quick patch to fix the problem I saw earlier tonight.

LGTM - pushed !
> Regards,
> Richard Sharpe
> (何以解憂?唯有杜康。--曹操)

> From 8ea82aa102836f10d4aeb768b584a09165d18275 Mon Sep 17 00:00:00 2001
> From: Richard Sharpe <rsharpe at samba.org>
> Date: Wed, 23 Mar 2016 21:56:30 -0700
> Subject: [PATCH] Fix an obvious error where we were converting a UNIX error to
>  an NT STATUS but not returning it.
> 
> Signed-off-by: Richard Sharpe <rsharpe at samba.org>
> ---
>  source3/smbd/dosmode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
> index e403cac..ab2820d 100644
> --- a/source3/smbd/dosmode.c
> +++ b/source3/smbd/dosmode.c
> @@ -1041,7 +1041,7 @@ NTSTATUS set_create_timespec_ea(connection_struct *conn,
>  
>  	ret = file_set_dosmode(conn, smb_fname, dosmode, NULL, false);
>  	if (ret == -1) {
> -		map_nt_error_from_unix(errno);
> +		return map_nt_error_from_unix(errno);
>  	}
>  
>  	DEBUG(10,("set_create_timespec_ea: wrote create time EA for file %s\n",
> -- 
> 2.4.3
> 




More information about the samba-technical mailing list