[PATCH] vfs_acl_xattr: avoid setting POSIX acls if "ignore system acls" is set

Jeremy Allison jra at samba.org
Thu Mar 24 15:49:35 UTC 2016


On Thu, Mar 24, 2016 at 07:12:29AM +0200, Uri Simchoni wrote:
> On 03/23/2016 01:34 AM, Jeremy Allison wrote:
> > On Tue, Mar 22, 2016 at 10:19:42AM +0200, Uri Simchoni wrote:
> >> Hi,
> >>
> >> Attached patch avoids setting the POSIX ACLs to match the NT ACLs,
> >> if "ignore system acls" is set.
> >>
> >> I believe this new behavior is more consistent with the
> >> vfs_acl_xattr man page. It also has the following benefits:
> >> - Avoid unnecessary sid->xid translations
> >> - Better compatibility with Windows, since by default Windows does
> >> not enforce existence of "traverse folder" right on parent folders,
> >> and modifying POSIX ACLs on parent folders could cause the kernel to
> >> deny access (dunno how RichACLs would handle this one :( ).
> >>
> >> Passes local make test.
> >>
> >> Please review,
> > 
> > Nice work Uri ! Pushed to autobuild.
> > 
> > Cheers,
> > 
> > 	Jeremy.
> > 
> Hasn't landed in master yet. Did it fail?

finally went in. I think autobuild was having
problems.



More information about the samba-technical mailing list