[PATCH] Final removal of lp_posix_pathnames() from the smbd server main code paths.
jra at samba.org
Wed Mar 23 22:11:24 UTC 2016
On Thu, Mar 24, 2016 at 12:02:48AM +0200, Uri Simchoni wrote:
> I started reviewing it, here's where I am (note the one comment):
> >>> 13). Remove lp_posix_pathnames() from msdfs code.
> >>> Last lp_posix_pathnames() in the SMB1/2/3 code paths.
> Not sure I quite get this one - lp_posix_pathnames() is derived from a
> protocol handshake and we're replacing it by a heuristic?
Yes, this isn't 100% compatibile with the previous
method. But it should work well enough in real-world
situations that it can replace it. And the the SMB2
case for msdfs there is no protocol handshake to look
at so I'm having to use what I have here.
For Windows clients, msdfs paths are always \\server\share\path
and '/' isn't allowed. For POSIX clients msdfs paths
The only possible problem here would be if a Windows
stream name contains a '/', then we might misinterpret
the path as posix.
Remember however this is only being looked at in
a client error case (I think it was WindowsXP
that did this) where it marked a local incoming
path as DFS.
More information about the samba-technical