Possible reason for f5a0ccc228ce1ef failure

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Mar 23 19:56:03 UTC 2016


On Thu, Mar 24, 2016 at 07:21:48AM +1300, Andrew Bartlett wrote:
> > You mean you think it's the right thing to do? Pull a gid
> > from a different winbind than this is going to be used in?
> 
> No, the opposite: Separating the ranges is the right thing to do!
> 
> I'm going to look into the socket path issue, I don't know why that is
> the case but I agree it is most suspicious. 

Alternatively, you might want to push the attached patchset.
Metze has just fixed the underlying issue I believe. It did
survive a private autobuild for me.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 4d8dc1edc5f2188c3857b7bc6d9901ad52ad5339 Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze at samba.org>
Date: Tue, 22 Mar 2016 14:09:08 +0100
Subject: [PATCH 1/2] selftest/Samba3: use the correct
 "SELFTEST_WINBINDD_SOCKET_DIR" for "net join"

This avoids picking up a gid from the DC's winbind when
creating BUILTIN\Administrators

Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
---
 selftest/target/Samba3.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 5dc4b17..7c494b3 100755
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -342,6 +342,7 @@ sub setup_nt4_member($$$)
 	my $net = Samba::bindir_path($self, "net");
 	my $cmd = "";
 	$cmd .= "SOCKET_WRAPPER_DEFAULT_IFACE=\"$ret->{SOCKET_WRAPPER_DEFAULT_IFACE}\" ";
+	$cmd .= "SELFTEST_WINBINDD_SOCKET_DIR=\"$ret->{SELFTEST_WINBINDD_SOCKET_DIR}\" ";
 	$cmd .= "$net join $ret->{CONFIGURATION} $nt4_dc_vars->{DOMAIN} member";
 	$cmd .= " -U$nt4_dc_vars->{USERNAME}\%$nt4_dc_vars->{PASSWORD}";
 
@@ -417,6 +418,7 @@ sub setup_admember($$$$)
 		$cmd .= "RESOLV_WRAPPER_HOSTS=\"$ret->{RESOLV_WRAPPER_HOSTS}\" ";
 	}
 	$cmd .= "KRB5_CONFIG=\"$ret->{KRB5_CONFIG}\" ";
+	$cmd .= "SELFTEST_WINBINDD_SOCKET_DIR=\"$ret->{SELFTEST_WINBINDD_SOCKET_DIR}\" ";
 	$cmd .= "$net join $ret->{CONFIGURATION}";
 	$cmd .= " -U$dcvars->{USERNAME}\%$dcvars->{PASSWORD}";
 
@@ -505,6 +507,7 @@ sub setup_admember_rfc2307($$$$)
 		$cmd .= "RESOLV_WRAPPER_HOSTS=\"$ret->{RESOLV_WRAPPER_HOSTS}\" ";
 	}
 	$cmd .= "KRB5_CONFIG=\"$ret->{KRB5_CONFIG}\" ";
+	$cmd .= "SELFTEST_WINBINDD_SOCKET_DIR=\"$ret->{SELFTEST_WINBINDD_SOCKET_DIR}\" ";
 	$cmd .= "$net join $ret->{CONFIGURATION}";
 	$cmd .= " -U$dcvars->{USERNAME}\%$dcvars->{PASSWORD}";
 
-- 
1.9.1


From 3d65c36f743955ab8a0e197afef9daba3249c5f4 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Wed, 23 Mar 2016 15:39:36 +0100
Subject: [PATCH 2/2] selftest: Unfail a few nss tests

The previous patch removed the gid collision

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 selftest/knownfail | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/selftest/knownfail b/selftest/knownfail
index 83cf2d6..7e533bf 100644
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -270,13 +270,6 @@
 ^samba3.local.nss.reentrant enumeration\(ad_dc:local\)
 ^samba3.local.nss.enumeration\(ad_dc:local\)
 #
-# These fail only if we run the unix.whoami test before them
-# in the member and ad_member environments. ==> Strange!!!
-#
-^samba3.local.nss.reentrant enumeration crosschecks\(ad_member:local\)
-^samba3.local.nss.reentrant enumeration\(ad_member:local\)
-^samba3.local.nss.enumeration\(ad_member:local\)
-#
 # These do not work against winbindd in member mode for unknown reasons
 #
 ^samba.blackbox.wbinfo\(ad_member:local\).wbinfo -U against ad_member\(ad_member:local\)
-- 
1.9.1



More information about the samba-technical mailing list