[PATCH] Final removal of lp_posix_pathnames() from the smbd server main code paths.
scott.lovenberg at gmail.com
Wed Mar 23 17:52:54 UTC 2016
On Wed, Mar 23, 2016 at 11:46 AM, Michael Adam <obnox at samba.org> wrote:
> On 2016-03-23 at 09:13 -0700, Jeremy Allison wrote:
> > On Tue, Mar 22, 2016 at 08:47:15AM -0700, Jeremy Allison wrote:
> > > On Sun, Mar 20, 2016 at 09:31:40PM -0700, Jeremy Allison wrote:
> > > > This is the final removal of all the
> > > > lp_posix_pathnames() globals from the
> > > > SMB1/2/3 server code paths (except for
> > > > the per-request lookup in the SMB1 server).
> > > >
> > > > Please review and push if happy !
> > >
> > > Updated version containing the flag definition
> > > change requested by Ralph.
> > I know people are really busy with other More.Important.Things. :-(
> > right now.
> > But for those who aren't, it'd be really great to get this in
> > as then I can start prototyping the SMB2 unix extensions !
> No worries! Your great work will not be forgotten!
> (I intend to review, but do not promise that I will manage
> to complete before the easter week-end..)
> Cheers - Michael
I haven't had a chance to look over the full set, but I'd be curious
if anyone has a reasonable estimate (or WAG) on the performance impact
of this whole set one way or the other. Nothing sticks out as slow
(not that my gut instincts on performance characteristics of code are
ever remotely accurate!), but a nagging voice in the back of my head
keeps suggesting that this seems like too good of a flexibility trade
off without a performance impact, clean as the code may be.
If my past estimates are anything to go by, this is probably actually
faster with a smaller footprint (deeper stack depth though at first
glance), but my curiosity overrides my desire to not make myself look
Peace and Blessings,
More information about the samba-technical