Master build breaks --without-ad-dc and bundled heimdal

[Alexander Bokovoy]

On Wed, 23 Mar 2016, Uri Simchoni wrote:
> When building master --without-ad-dc and bundled heimdal, I get the
> following error when the build begins:
> 
> Checking project rules ...
> Unknown dependency 'HDB_SAMBA4' in 'python_dckeytab.objlist'
> 
> To reproduce (FC23 but probably others too):
> ./configure --without-ad-dc
> make
> 
> No problems with 4.4.0.
> 
> The immediate suspect would be mit-kdb addition, commit
> ade958e20b561b702e2fec86a28659144dbe4a9e, but I can't see the link. I'm
> bisecting to find the commit, but if someone more familiar with this area of
> the code can do an "Aha!" and save me the work I'd be grateful.
Attached should fix the problem.

-- 
/ Alexander Bokovoy
-------------- next part --------------
>From 983931ffedf7e98e7ab971d143d2d1efa4d07dea Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <ab at samba.org>
Date: Wed, 23 Mar 2016 08:15:34 +0200
Subject: [PATCH] s4-libnet: only build python-dckeytab module for Heimdal in
 AD DC mode

Signed-off-by: Alexander Bokovoy <ab at samba.org>
---
 source4/libnet/wscript_build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source4/libnet/wscript_build b/source4/libnet/wscript_build
index 6cca50d..daae59f 100644
--- a/source4/libnet/wscript_build
+++ b/source4/libnet/wscript_build
@@ -18,5 +18,5 @@ bld.SAMBA_PYTHON('python_dckeytab',
 	source='py_net_dckeytab.c libnet_export_keytab.c',
 	deps='pyrpc_util HDB_SAMBA4 com_err',
 	realname='samba/dckeytab.so',
-        enabled=bld.CONFIG_SET('SAMBA4_USES_HEIMDAL')
+        enabled=bld.CONFIG_SET('SAMBA4_USES_HEIMDAL') and bld.CONFIG_SET('AD_DC_BUILD_IS_ENABLED')
 	)
-- 
2.5.0