[PATCH] torture: Fix the O3 developer build

[Michael Adam]

On 2016-03-22 at 17:20 +0100, Volker Lendecke wrote:
> On Tue, Mar 22, 2016 at 05:05:55PM +0100, Michael Adam wrote:
> > On 2016-03-22 at 08:50 -0700, Jeremy Allison wrote:
> > > On Tue, Mar 22, 2016 at 04:05:50PM +0100, Volker Lendecke wrote:
> > > > Hi!
> > > > 
> > > > Apologies for the repeated mails in this regard: Is anybody on this list
> > > > still interested in this kind of spam, or do you want me to keep them
> > > > local in my tree?
> > > 
> > > Yes, yes 1000x yes - please keep them coming :-).
> > 
> > Indeed... Jeremy was again faster... :-)
> > 
> > I guess the actual message (instead of apologies) was
> > "When will you guys finally be careful enough with the code
> > you write, so that I don't have to fix up behind you?..."
> 
> Right. The question really is -- if I'm the only one compiling with
> -O3 for the additional warnings, the Samba Team as a whole does not
> see this as a priority.

We are all just lazy farts, and not implicitly neglcting -O3 but
relying on you... I propose that we add a -O3 build target
to our autobuild, so that there are no excuses.

See the attached patch.

Note that this fails on my f23 box... need to fix a few
O3 bugs as it seems ... :-)

Cheers - Michael

-------------- next part --------------
From 7d8f394f93160b58a4c7c1e5fd2c2314c18ac94d Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Tue, 22 Mar 2016 18:14:17 +0100
Subject: [PATCH] autobuild: add a target samba-o3 that is built with -O3

Signed-off-by: Michael Adam <obnox at samba.org>
---
 script/autobuild.py | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/script/autobuild.py b/script/autobuild.py
index 13be1b6..71a5467 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -24,6 +24,7 @@ builddirs = {
     "ctdb"    : "ctdb",
     "samba"  : ".",
     "samba-xc" : ".",
+    "samba-o3" : ".",
     "samba-ctdb" : ".",
     "samba-libs"  : ".",
     "samba-static"  : ".",
@@ -38,7 +39,7 @@ builddirs = {
     "retry"   : "."
     }
 
-defaulttasks = [ "ctdb", "samba", "samba-xc", "samba-ctdb", "samba-libs", "samba-static", "ldb", "tdb", "talloc", "replace", "tevent", "pidl" ]
+defaulttasks = [ "ctdb", "samba", "samba-xc", "samba-o3", "samba-ctdb", "samba-libs", "samba-static", "ldb", "tdb", "talloc", "replace", "tevent", "pidl" ]
 
 samba_configure_params = " --picky-developer ${PREFIX} ${EXTRA_PYTHON} --with-profiling-data"
 
@@ -79,6 +80,14 @@ tasks = {
                     " --cross-answers=./bin-xe/cross-answers.txt --with-selftest-prefix=./bin-xa/ab" + samba_configure_params, "text/plain"),
                    ("compare-results", "script/compare_cc_results.py ./bin/c4che/default.cache.py ./bin-xe/c4che/default.cache.py ./bin-xa/c4che/default.cache.py", "text/plain")],
 
+    # test build with -O3 -- catches extra warnings and bugs
+    "samba-o3" : [ ("random-sleep", "../script/random-sleep.sh 60 600", "text/plain"),
+                   ("configure", "ADDITIONAL_CFLAGS='-O3' ./configure.developer --with-selftest-prefix=./bin/ab" + samba_configure_params, "text/plain"),
+                   ("make", "make -j", "text/plain"),
+                   ("test", "make quicktest FAIL_IMMEDIATELY=1 TESTS='\(ad_dc\)'", "text/plain"),
+                   ("install", "make install", "text/plain"),
+                   ("check-clean-tree", "script/clean-source-tree.sh", "text/plain"),
+                   ("clean", "make clean", "text/plain") ],
 
     "samba-ctdb" : [ ("random-sleep", "script/random-sleep.sh 60 600", "text/plain"),
 
-- 
2.5.5

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160322/d3004ee5/signature.sig>