[PATCH] Final removal of lp_posix_pathnames() from the smbd server main code paths.
jra at samba.org
Tue Mar 22 15:34:57 UTC 2016
On Tue, Mar 22, 2016 at 12:17:22PM +0100, Ralph Boehme wrote:
> On Sun, Mar 20, 2016 at 09:31:40PM -0700, Jeremy Allison wrote:
> > 4). Add uint32_t flags field to struct smb_filename. Only
> > defined field currently is SMB_FILENAME_POSIX_PATH.
> we already have
> #define FSP_POSIX_FLAGS_OPEN 0x01
> #define FSP_POSIX_FLAGS_RENAME 0x02
> #define FSP_POSIX_FLAGS_PATHNAMES 0x04
> in vfs.h. Can we somehow align/reuse the flags?
> I'm afraid that having essentially the same flags for struct
> smb_filename and files_struct is confusing in the long term.
Err. Sure - the names don't match though, due
to the FSP_XXX component.
But I can certainly define the SMB_FILENAME_XX_FLAG
in terms of the FSP_POSIX_FLAGS_XX.
The only one that applies is FSP_POSIX_FLAGS_PATHNAMES,
as the others cover attributes of open files (locking,
renames etc.) that simply don't apply to pure pathnames.
More information about the samba-technical