[WIP][PATCH] Improve replication with rename handling

Mon Mar 21 03:57:34 UTC 2016

G'Day,

Attached, and in repl-rename-fixes-for-master on
git://git.catalyst.net.nz/samba.git is a patch set to deal with a
number of replication issues we have found, particularly around rename
handling in Samba.

In short, we now follow the spec and retry replication
with DRSUAPI_DRS_GET_ANC rather than simply hoping the parent will show
up eventually.  This makes a number of the nasty tests we wrote pass,
where previously they would accidentally leave child objects under the
wrong parent objects.

This may address some of our dbcheck failures in autobuild.  I'll know
more when the 10 builds I have in the Catalyst Cloud report later
tonight.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-autobuild-Return-the-last-50-log-lines.patch
Type: text/x-patch
Size: 1579 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0001-autobuild-Return-the-last-50-log-lines-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-samba-tool-domain-join-Set-drsuapi.DRSUAPI_DRS_GET_A.patch
Type: text/x-patch
Size: 2207 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0002-samba-tool-domain-join-Set-drsuapi.DRSUAPI_DRS_GET_A-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-repl-Enforce-that-we-have-parent-objects-for-all-rep.patch
Type: text/x-patch
Size: 16302 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0003-repl-Enforce-that-we-have-parent-objects-for-all-rep-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-repl_meta_data-Explain-why-time-NULL-is-good-enough-.patch
Type: text/x-patch
Size: 1100 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0004-repl_meta_data-Explain-why-time-NULL-is-good-enough--0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-rpc_server-drsuapi-Return-the-correct-3-objects-for-.patch
Type: text/x-patch
Size: 11377 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0005-rpc_server-drsuapi-Return-the-correct-3-objects-for--0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-repl-Turn-failed-extended-operations-into-a-normal-f.patch
Type: text/x-patch
Size: 2292 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0006-repl-Turn-failed-extended-operations-into-a-normal-f-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-getncchanges-Give-the-correct-error-when-RID_ALLOC-f.patch
Type: text/x-patch
Size: 3072 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0007-getncchanges-Give-the-correct-error-when-RID_ALLOC-f-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-getncchanges-Use-the-talloc_stackframe-for-tempory-m.patch
Type: text/x-patch
Size: 1972 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0008-getncchanges-Use-the-talloc_stackframe-for-tempory-m-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-getncchanges-Fill-in-ctr6.linked_attributes-with-a-p.patch
Type: text/x-patch
Size: 2220 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0009-getncchanges-Fill-in-ctr6.linked_attributes-with-a-p-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-ldb-Fix-error-string-when-renaming-to-an-DN-that-alr.patch
Type: text/x-patch
Size: 1048 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0010-ldb-Fix-error-string-when-renaming-to-an-DN-that-alr-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-dsdb-Improve-syntax-clarity.patch
Type: text/x-patch
Size: 1067 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0011-dsdb-Improve-syntax-clarity-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-dsdb-Clearly-fail-to-replicate-objects-not-NC_HEAD-w.patch
Type: text/x-patch
Size: 1111 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0012-dsdb-Clearly-fail-to-replicate-objects-not-NC_HEAD-w-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-dsdb-Move-operational-below-repl_meta_data-so-we-can.patch
Type: text/x-patch
Size: 3222 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0013-dsdb-Move-operational-below-repl_meta_data-so-we-can-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-dsdb-Give-more-errors-in-operational-module-when-bui.patch
Type: text/x-patch
Size: 1383 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0014-dsdb-Give-more-errors-in-operational-module-when-bui-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-dsdb-Clarify-rename-handling-as-to-which-record-is-b.patch
Type: text/x-patch
Size: 1115 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0015-dsdb-Clarify-rename-handling-as-to-which-record-is-b-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-repl_meta_data-Fail-to-replicate-over-local-objects-.patch
Type: text/x-patch
Size: 2412 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0016-repl_meta_data-Fail-to-replicate-over-local-objects--0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-repl_meta_data-Give-more-information-on-replication-.patch
Type: text/x-patch
Size: 3155 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0017-repl_meta_data-Give-more-information-on-replication--0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0018-dsdb-subtree_rename-Rename-the-base-before-we-rename.patch
Type: text/x-patch
Size: 4465 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0018-dsdb-subtree_rename-Rename-the-base-before-we-rename-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0019-dsdb-Improve-debug-messages-in-operational-module.patch
Type: text/x-patch
Size: 1479 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0019-dsdb-Improve-debug-messages-in-operational-module-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0020-dsdb-Ensure-that-after-conflict-resolution-we-still-.patch
Type: text/x-patch
Size: 1548 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0020-dsdb-Ensure-that-after-conflict-resolution-we-still--0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0021-dsdb-Give-the-objectGUID-ahead-of-LDIF-dump-of-repli.patch
Type: text/x-patch
Size: 1233 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0021-dsdb-Give-the-objectGUID-ahead-of-LDIF-dump-of-repli-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0022-selftest-initial-version-of-new-repl_move-test.patch
Type: text/x-patch
Size: 43953 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0022-selftest-initial-version-of-new-repl_move-test-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0023-selftest-drs-Show-we-return-the-correct-3-objects-fo.patch
Type: text/x-patch
Size: 10730 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0023-selftest-drs-Show-we-return-the-correct-3-objects-fo-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0024-rpc_server-drsuapi-Ensure-we-always-return-the-fixed.patch
Type: text/x-patch
Size: 1685 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0024-rpc_server-drsuapi-Ensure-we-always-return-the-fixed-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0025-repl-Pass-in-the-full-partition-DN-to-dsdb_replicate.patch
Type: text/x-patch
Size: 8144 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0025-repl-Pass-in-the-full-partition-DN-to-dsdb_replicate-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0026-repl-Do-not-report-all-replication-failures-at-level.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160321/f46e09fc/0026-repl-Do-not-report-all-replication-failures-at-level-0001.bin>