[PATCHSET] Add MIT KDC kdb driver for Samba

Andreas Schneider asn at samba.org
Thu Mar 17 08:12:49 UTC 2016


On Thursday 17 March 2016 21:08:23 Andrew Bartlett wrote:
> On Thu, 2016-03-17 at 09:03 +0100, Andreas Schneider wrote:
> > On Thursday 17 March 2016 15:26:30 Andrew Bartlett wrote:
> > > On Thu, 2016-03-10 at 16:51 +0100, Andreas Schneider wrote:
> > > > On Thursday 04 February 2016 10:27:48 Andreas Schneider wrote:
> > > > > Hello,
> > > > > 
> > > > > the attached patchset adds a mit_samba a shim layer between
> > > > > Samba
> > > > > and KDB
> > > > > and a KDB driver for the MIT KDC.
> > > > > 
> > > > > Sumit has reviewed the patchset already and we fixed two small
> > > > > issues. We
> > > > > run Coverity on the code and it didn't find an issue.
> > > > > 
> > > > > ## master-mit-kdc-ok...origin/master [ahead 29]
> > > > > 
> > > > > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/
> > > > > mast
> > > > > er-mit-kd
> > > > > c-ok
> > > > 
> > > > This patchset is waiting for review more than a month now.
> > > > 
> > > > Attached is a rebased patchset on master. It holds enough review
> > > > to
> > > > be able to
> > > > be pushed to master. This code is in our master-mit-kdc branch
> > > > for
> > > > probably a
> > > > year now. G√ľnther and I already looked over this patches already
> > > > several times
> > > > and Sumit Bose did another review of the code lately.
> > > > 
> > > > If you care about this patchset please review it, if nobody
> > > > objects
> > > > till next
> > > > Thursday or ask for a hold, I will push it to master.
> > > 
> > > I've reviewed it and it is now in autobuild.
> > > 
> > > Thank you for your patience here.
> > 
> > Thank you very much Andrew.
> > 
> > I will rebase the master-mit-kdc branch. I'm currently working on
> > send and
> > receive hooks so we can implement the krb5 tests.
> > 
> > The hooks differ from the Heimdal ones, but provide some nice
> > features we
> > could make use of :)
> > 
> > https://github.com/gladiac/krb5/commits/master-sendto-kdc-hooks
> > 
> > I'm working on documentation right now, then I will add more tests
> > for the
> > corner cases.
> 
> Nice!  Thank you so much for taking this on.
> 
> BTW, have you tested your MIT backed Samba4 with a Heimdal-compiled
> krb5.kdc test?  How did it fare?

They did not work, but I don't remember the details. I think I got one test 
working after commenting out some code.

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list