[PATCH] Move socket_wrapper to third_party

Andreas Schneider asn at samba.org
Wed Mar 16 17:04:10 UTC 2016

On Wednesday 16 March 2016 15:52:28 Volker Lendecke wrote:
> On Wed, Mar 16, 2016 at 02:34:42PM +0100, Andreas Schneider wrote:
> > Hi,
> > 
> > could we move socket_wrapper to the third_party directory and handle it
> > with updates like the other?
> > 
> > Till now we manually ported each commit of any wrapper to Samba. This way
> > we had the history in the Samba repository. But do we really need to have
> > the history twice?
> > 
> > It probably made sense in the beginning but we have so many tests for the
> > wrappers which even Samba do not trigger at all.
> > 
> > It would be less work to update a wrapper in the Samba soruce tree.
> > 
> > What do you think?
> We had this discussion in the past. What has changed since then?

Before cwrap the testsuite for the wrappers was running Samba in selftest. We 
are past that in the meantime. We have really good code coverage.

Features are not implemented for Samba only. The features we implemented in 
the last months were for other projects (libssh, sssd, ..). The more projects 
cwrap use the more bugfixes we get and the tests are added or extended.

Manually porting requires quite some time. In the meantime the wrappers are in 
a state, that if we update them in Samba or run Samba with newer version, we 
find bugs in the Samba code and not the other way.

Sometimes the support for of some feature inside the wrapper are not complete, 
if we fix them we start to see bugs in the Samba code. This was the case when 
we implemented better getaddrinfo() IPv6 support and handling of 
AI_NUMERICHOST in a strict way in nss_wrapper. When adding it to Samba, we 
found several issues in the Samba code, fixed by Michael.

Here is an example:


The issues show up when we add the wrappers to Samba and run 'make test' with 
the latest version.

The development is done with writing tests at the same time as coding the 
features for the wrappers.

I don't remember the reason why metze wanted it in the first place. Maybe he 
can answer that.

Best regards,

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list