[PATCH] lib: Fix the O3 developer build on RHEL 7.1

Michael Adam obnox at samba.org
Wed Mar 16 11:29:26 UTC 2016


It seems this is already fixed in upstream master:

https://git.samba.org/?p=uid_wrapper.git;a=shortlog;h=refs/heads/master
https://git.samba.org/?p=uid_wrapper.git;a=commitdiff;h=3df97e0e690fe811f620ee9afef898bf896eb41c

The proper process would be to tag an upstream release
and port the patches back, I guess?

At least I have heard that there is some kind of (unwritten?)
policy to only take full releases and not patches inbetween.

So I request that we either do a release of uid_wrapper asap
or accept porting patches without a release.

Thanks - Michael



On 2016-03-14 at 15:39 +0100, Volker Lendecke wrote:
> Hi!
> 
> Review appreciated!
> 
> Thanks, Volker
> 
> -- 
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de

> From bd1c12ad155ad6584ebf2ce4f970299bc2a8c691 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Mon, 14 Mar 2016 15:37:54 +0100
> Subject: [PATCH] lib: Fix the O3 developer build on RHEL 7.1
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  lib/uid_wrapper/uid_wrapper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/uid_wrapper/uid_wrapper.c b/lib/uid_wrapper/uid_wrapper.c
> index ab47dd0..5e33d2d 100644
> --- a/lib/uid_wrapper/uid_wrapper.c
> +++ b/lib/uid_wrapper/uid_wrapper.c
> @@ -156,7 +156,7 @@ static void uwrap_log(enum uwrap_dbglvl_e dbglvl, const char *function, const ch
>  	va_end(va);
>  
>  	if (lvl >= dbglvl) {
> -		const char *prefix;
> +		const char *prefix = "";
>  		switch (dbglvl) {
>  			case UWRAP_LOG_ERROR:
>  				prefix = "UWRAP_ERROR";
> -- 
> 1.8.3.1
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160316/ea16a144/signature.sig>


More information about the samba-technical mailing list