[PATCH] support quota on Solaris 10

Jeremy Allison jra at samba.org
Sun Mar 13 05:38:27 UTC 2016

On Sun, Mar 13, 2016 at 07:35:28AM +0200, Uri Simchoni wrote:
> On 03/12/2016 11:19 PM, Jeremy Allison wrote:
> >
> >The #ifdef's in here are an utter rats nest though :-).
> >
> >Maybe a follow up patch could add comments before the
> >#else and #endif tags so engineers can see which #ifdef
> >they're referring to.
> >
> You mean something like this?

Exactly that, yeah. Thanks for doing that work !

Pushed :-)

> Yeah the #ifdefs are quite puzzling, but I wanted to maintain the original
> file structure.
> I did some digging to make sensible comments and it seems like we can delete
> the SunOS4 and Solaris 2 parts. That would simplify things a bit, and maybe
> also the AIX parts (b/c AIX 4.x and 5.x are beyond end-of support - the
> latest AIX effort, backed by IBM, should implement the new quota interface).

Sounds good to me.

More information about the samba-technical mailing list